<html>
<head><meta charset="utf-8"><title>review request: PR #84867 (revert of PR 80653) · rustdoc · Zulip Chat Archive</title></head>
<h2>Stream: <a href="https://rust-lang.github.io/zulip_archive/stream/266220-rustdoc/index.html">rustdoc</a></h2>
<h3>Topic: <a href="https://rust-lang.github.io/zulip_archive/stream/266220-rustdoc/topic/review.20request.3A.20PR.20.2384867.20(revert.20of.20PR.2080653).html">review request: PR #84867 (revert of PR 80653)</a></h3>

<hr>

<base href="https://rust-lang.zulipchat.com">

<head><link href="https://rust-lang.github.io/zulip_archive/style.css" rel="stylesheet"></head>

<a name="237167421"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/266220-rustdoc/topic/review%20request%3A%20PR%20%2384867%20%28revert%20of%20PR%2080653%29/near/237167421" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/266220-rustdoc/topic/review.20request.3A.20PR.20.2384867.20(revert.20of.20PR.2080653).html#237167421">(May 03 2021 at 14:18)</a>:</h4>
<p>Hi T-rustdoc</p>



<a name="237167472"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/266220-rustdoc/topic/review%20request%3A%20PR%20%2384867%20%28revert%20of%20PR%2080653%29/near/237167472" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/266220-rustdoc/topic/review.20request.3A.20PR.20.2384867.20(revert.20of.20PR.2080653).html#237167472">(May 03 2021 at 14:19)</a>:</h4>
<p>Unfortunately I wasn’t able to just trivially <code>git revert</code> PR <a href="https://github.com/rust-lang/rust/issues/80653">#80653</a></p>



<a name="237167513"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/266220-rustdoc/topic/review%20request%3A%20PR%20%2384867%20%28revert%20of%20PR%2080653%29/near/237167513" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/266220-rustdoc/topic/review.20request.3A.20PR.20.2384867.20(revert.20of.20PR.2080653).html#237167513">(May 03 2021 at 14:19)</a>:</h4>
<p>so PR <a href="https://github.com/rust-lang/rust/issues/84867">#84867</a> is my attempt to manually craft a revert</p>



<a name="237167588"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/266220-rustdoc/topic/review%20request%3A%20PR%20%2384867%20%28revert%20of%20PR%2080653%29/near/237167588" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/266220-rustdoc/topic/review.20request.3A.20PR.20.2384867.20(revert.20of.20PR.2080653).html#237167588">(May 03 2021 at 14:20)</a>:</h4>
<p>It adds a regression test for <a href="https://github.com/rust-lang/rust/issues/82465">#82465</a>. I verified that the regressiont test fails without this PR, and passes with this PR.</p>



<a name="237167732"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/266220-rustdoc/topic/review%20request%3A%20PR%20%2384867%20%28revert%20of%20PR%2080653%29/near/237167732" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/266220-rustdoc/topic/review.20request.3A.20PR.20.2384867.20(revert.20of.20PR.2080653).html#237167732">(May 03 2021 at 14:20)</a>:</h4>
<p><span class="user-mention" data-user-id="116083">@pnkfelix</span> hmm was this meant to go into 1.52? Do we need to cherry-pick this onto the currently in CI promotion?</p>



<a name="237167757"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/266220-rustdoc/topic/review%20request%3A%20PR%20%2384867%20%28revert%20of%20PR%2080653%29/near/237167757" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/266220-rustdoc/topic/review.20request.3A.20PR.20.2384867.20(revert.20of.20PR.2080653).html#237167757">(May 03 2021 at 14:21)</a>:</h4>
<p>seems like likely yes</p>



<a name="237167949"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/266220-rustdoc/topic/review%20request%3A%20PR%20%2384867%20%28revert%20of%20PR%2080653%29/near/237167949" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/266220-rustdoc/topic/review.20request.3A.20PR.20.2384867.20(revert.20of.20PR.2080653).html#237167949">(May 03 2021 at 14:22)</a>:</h4>
<p>unfortunately your PR doesn't land on beta/stable branches (both largely identical at this moment) cleanly</p>



<a name="237168085"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/266220-rustdoc/topic/review%20request%3A%20PR%20%2384867%20%28revert%20of%20PR%2080653%29/near/237168085" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/266220-rustdoc/topic/review.20request.3A.20PR.20.2384867.20(revert.20of.20PR.2080653).html#237168085">(May 03 2021 at 14:23)</a>:</h4>
<p>let me see if the actual PR reverts cleanly</p>



<a name="237168108"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/266220-rustdoc/topic/review%20request%3A%20PR%20%2384867%20%28revert%20of%20PR%2080653%29/near/237168108" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/266220-rustdoc/topic/review.20request.3A.20PR.20.2384867.20(revert.20of.20PR.2080653).html#237168108">(May 03 2021 at 14:23)</a>:</h4>
<p>cc <span class="user-mention" data-user-id="121055">@Pietro Albini</span></p>



<a name="237168151"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/266220-rustdoc/topic/review%20request%3A%20PR%20%2384867%20%28revert%20of%20PR%2080653%29/near/237168151" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/266220-rustdoc/topic/review.20request.3A.20PR.20.2384867.20(revert.20of.20PR.2080653).html#237168151">(May 03 2021 at 14:23)</a>:</h4>
<p>er, cc <span class="user-mention" data-user-id="121055">@Pietro Albini</span> (now subscribed)</p>



<a name="237168212"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/266220-rustdoc/topic/review%20request%3A%20PR%20%2384867%20%28revert%20of%20PR%2080653%29/near/237168212" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/266220-rustdoc/topic/review.20request.3A.20PR.20.2384867.20(revert.20of.20PR.2080653).html#237168212">(May 03 2021 at 14:24)</a>:</h4>
<p>no, it doesn't</p>



<a name="237168215"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/266220-rustdoc/topic/review%20request%3A%20PR%20%2384867%20%28revert%20of%20PR%2080653%29/near/237168215" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/266220-rustdoc/topic/review.20request.3A.20PR.20.2384867.20(revert.20of.20PR.2080653).html#237168215">(May 03 2021 at 14:24)</a>:</h4>
<p>gah</p>



<a name="237168283"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/266220-rustdoc/topic/review%20request%3A%20PR%20%2384867%20%28revert%20of%20PR%2080653%29/near/237168283" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/266220-rustdoc/topic/review.20request.3A.20PR.20.2384867.20(revert.20of.20PR.2080653).html#237168283">(May 03 2021 at 14:24)</a>:</h4>
<p><span class="user-mention" data-user-id="116083">@pnkfelix</span> if you could craft a revert that backports onto beta cleanly, that'd be amazing.</p>



<a name="237168583"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/266220-rustdoc/topic/review%20request%3A%20PR%20%2384867%20%28revert%20of%20PR%2080653%29/near/237168583" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/266220-rustdoc/topic/review.20request.3A.20PR.20.2384867.20(revert.20of.20PR.2080653).html#237168583">(May 03 2021 at 14:26)</a>:</h4>
<p>okay I think I can do that</p>



<a name="237168595"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/266220-rustdoc/topic/review%20request%3A%20PR%20%2384867%20%28revert%20of%20PR%2080653%29/near/237168595" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/266220-rustdoc/topic/review.20request.3A.20PR.20.2384867.20(revert.20of.20PR.2080653).html#237168595">(May 03 2021 at 14:26)</a>:</h4>
<p>(It was indeed meant to go into 1.52)</p>



<a name="237169679"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/266220-rustdoc/topic/review%20request%3A%20PR%20%2384867%20%28revert%20of%20PR%2080653%29/near/237169679" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/266220-rustdoc/topic/review.20request.3A.20PR.20.2384867.20(revert.20of.20PR.2080653).html#237169679">(May 03 2021 at 14:33)</a>:</h4>
<p>But I had another question about this</p>



<a name="237169688"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/266220-rustdoc/topic/review%20request%3A%20PR%20%2384867%20%28revert%20of%20PR%2080653%29/near/237169688" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/266220-rustdoc/topic/review.20request.3A.20PR.20.2384867.20(revert.20of.20PR.2080653).html#237169688">(May 03 2021 at 14:33)</a>:</h4>
<p>the test suite, I cannot tell from skimming it</p>



<a name="237169724"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/266220-rustdoc/topic/review%20request%3A%20PR%20%2384867%20%28revert%20of%20PR%2080653%29/near/237169724" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/266220-rustdoc/topic/review.20request.3A.20PR.20.2384867.20(revert.20of.20PR.2080653).html#237169724">(May 03 2021 at 14:34)</a>:</h4>
<p>whehter we tend to rely on the rustdoc test suite alone</p>



<a name="237169800"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/266220-rustdoc/topic/review%20request%3A%20PR%20%2384867%20%28revert%20of%20PR%2080653%29/near/237169800" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/266220-rustdoc/topic/review.20request.3A.20PR.20.2384867.20(revert.20of.20PR.2080653).html#237169800">(May 03 2021 at 14:34)</a>:</h4>
<p>or if we require some human activity as well before a release, to visually check things out?</p>



<a name="237171696"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/266220-rustdoc/topic/review%20request%3A%20PR%20%2384867%20%28revert%20of%20PR%2080653%29/near/237171696" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Joshua Nelson <a href="https://rust-lang.github.io/zulip_archive/stream/266220-rustdoc/topic/review.20request.3A.20PR.20.2384867.20(revert.20of.20PR.2080653).html#237171696">(May 03 2021 at 14:46)</a>:</h4>
<p><span class="user-mention silent" data-user-id="116083">pnkfelix</span> <a href="#narrow/stream/266220-rustdoc/topic/review.20request.3A.20PR.20.2384867.20.28revert.20of.20PR.2080653.29/near/237169724">said</a>:</p>
<blockquote>
<p>whehter we tend to rely on the rustdoc test suite alone</p>
</blockquote>
<p>usually yes</p>



<a name="237171729"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/266220-rustdoc/topic/review%20request%3A%20PR%20%2384867%20%28revert%20of%20PR%2080653%29/near/237171729" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Joshua Nelson <a href="https://rust-lang.github.io/zulip_archive/stream/266220-rustdoc/topic/review.20request.3A.20PR.20.2384867.20(revert.20of.20PR.2080653).html#237171729">(May 03 2021 at 14:46)</a>:</h4>
<p>it's not as complete as it should be, but if your new test passes it should be fine</p>



<a name="237174885"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/266220-rustdoc/topic/review%20request%3A%20PR%20%2384867%20%28revert%20of%20PR%2080653%29/near/237174885" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/266220-rustdoc/topic/review.20request.3A.20PR.20.2384867.20(revert.20of.20PR.2080653).html#237174885">(May 03 2021 at 15:02)</a>:</h4>
<p>Is the htmlck tool something homegrown?</p>



<a name="237176716"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/266220-rustdoc/topic/review%20request%3A%20PR%20%2384867%20%28revert%20of%20PR%2080653%29/near/237176716" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Joshua Nelson <a href="https://rust-lang.github.io/zulip_archive/stream/266220-rustdoc/topic/review.20request.3A.20PR.20.2384867.20(revert.20of.20PR.2080653).html#237176716">(May 03 2021 at 15:09)</a>:</h4>
<p>yes, almost all the test suites are handwritten</p>



<a name="237176738"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/266220-rustdoc/topic/review%20request%3A%20PR%20%2384867%20%28revert%20of%20PR%2080653%29/near/237176738" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Joshua Nelson <a href="https://rust-lang.github.io/zulip_archive/stream/266220-rustdoc/topic/review.20request.3A.20PR.20.2384867.20(revert.20of.20PR.2080653).html#237176738">(May 03 2021 at 15:10)</a>:</h4>
<p>jsondocck too</p>



<a name="237176839"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/266220-rustdoc/topic/review%20request%3A%20PR%20%2384867%20%28revert%20of%20PR%2080653%29/near/237176839" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Joshua Nelson <a href="https://rust-lang.github.io/zulip_archive/stream/266220-rustdoc/topic/review.20request.3A.20PR.20.2384867.20(revert.20of.20PR.2080653).html#237176839">(May 03 2021 at 15:10)</a>:</h4>
<p>I'm hoping to consolidate htmldocck and jsondocck into the same rust tool at some point (python is hard to test and add dependencies for)</p>



<a name="237177024"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/266220-rustdoc/topic/review%20request%3A%20PR%20%2384867%20%28revert%20of%20PR%2080653%29/near/237177024" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Joshua Nelson <a href="https://rust-lang.github.io/zulip_archive/stream/266220-rustdoc/topic/review.20request.3A.20PR.20.2384867.20(revert.20of.20PR.2080653).html#237177024">(May 03 2021 at 15:11)</a>:</h4>
<p><span class="user-mention silent" data-user-id="116083">pnkfelix</span> <a href="#narrow/stream/266220-rustdoc/topic/review.20request.3A.20PR.20.2384867.20.28revert.20of.20PR.2080653.29/near/237174885">said</a>:</p>
<blockquote>
<p>Is the htmlck tool something homegrown?</p>
</blockquote>
<p>if you're looking for documentation there's some at <a href="https://rustc-dev-guide.rust-lang.org/rustdoc-internals.html#dotting-is-and-crossing-ts">https://rustc-dev-guide.rust-lang.org/rustdoc-internals.html#dotting-is-and-crossing-ts</a></p>



<a name="237180010"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/266220-rustdoc/topic/review%20request%3A%20PR%20%2384867%20%28revert%20of%20PR%2080653%29/near/237180010" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/266220-rustdoc/topic/review.20request.3A.20PR.20.2384867.20(revert.20of.20PR.2080653).html#237180010">(May 03 2021 at 15:27)</a>:</h4>
<p>Thanks!</p>



<a name="237180093"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/266220-rustdoc/topic/review%20request%3A%20PR%20%2384867%20%28revert%20of%20PR%2080653%29/near/237180093" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/266220-rustdoc/topic/review.20request.3A.20PR.20.2384867.20(revert.20of.20PR.2080653).html#237180093">(May 03 2021 at 15:27)</a>:</h4>
<p>I was musing about broader queries about the graph-structure represented by the page, i.e. trying to test the semantic content of the web site</p>



<a name="237180158"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/266220-rustdoc/topic/review%20request%3A%20PR%20%2384867%20%28revert%20of%20PR%2080653%29/near/237180158" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/266220-rustdoc/topic/review.20request.3A.20PR.20.2384867.20(revert.20of.20PR.2080653).html#237180158">(May 03 2021 at 15:28)</a>:</h4>
<p>(without caring about details like the specific id tags)</p>



<a name="237180280"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/266220-rustdoc/topic/review%20request%3A%20PR%20%2384867%20%28revert%20of%20PR%2080653%29/near/237180280" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Joshua Nelson <a href="https://rust-lang.github.io/zulip_archive/stream/266220-rustdoc/topic/review.20request.3A.20PR.20.2384867.20(revert.20of.20PR.2080653).html#237180280">(May 03 2021 at 15:29)</a>:</h4>
<p><span class="user-mention silent" data-user-id="116083">pnkfelix</span> <a href="#narrow/stream/266220-rustdoc/topic/review.20request.3A.20PR.20.2384867.20.28revert.20of.20PR.2080653.29/near/237180093">said</a>:</p>
<blockquote>
<p>I was musing about broader queries about the graph-structure represented by the page, i.e. trying to test the semantic content of the web site</p>
</blockquote>
<p>this would be really nice to have an automated check for</p>



<a name="237180300"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/266220-rustdoc/topic/review%20request%3A%20PR%20%2384867%20%28revert%20of%20PR%2080653%29/near/237180300" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Joshua Nelson <a href="https://rust-lang.github.io/zulip_archive/stream/266220-rustdoc/topic/review.20request.3A.20PR.20.2384867.20(revert.20of.20PR.2080653).html#237180300">(May 03 2021 at 15:29)</a>:</h4>
<p>I think the linkchecker does that for libstd docs</p>



<a name="237180337"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/266220-rustdoc/topic/review%20request%3A%20PR%20%2384867%20%28revert%20of%20PR%2080653%29/near/237180337" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Joshua Nelson <a href="https://rust-lang.github.io/zulip_archive/stream/266220-rustdoc/topic/review.20request.3A.20PR.20.2384867.20(revert.20of.20PR.2080653).html#237180337">(May 03 2021 at 15:29)</a>:</h4>
<p>I wonder if we could extend it to tests too</p>



<a name="237187400"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/266220-rustdoc/topic/review%20request%3A%20PR%20%2384867%20%28revert%20of%20PR%2080653%29/near/237187400" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/266220-rustdoc/topic/review.20request.3A.20PR.20.2384867.20(revert.20of.20PR.2080653).html#237187400">(May 03 2021 at 16:17)</a>:</h4>
<p><span class="user-mention" data-user-id="116083">@pnkfelix</span> any update on the tidy fixes?</p>



<a name="237187651"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/266220-rustdoc/topic/review%20request%3A%20PR%20%2384867%20%28revert%20of%20PR%2080653%29/near/237187651" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/266220-rustdoc/topic/review.20request.3A.20PR.20.2384867.20(revert.20of.20PR.2080653).html#237187651">(May 03 2021 at 16:19)</a>:</h4>
<p>They are on their way</p>



<a name="237187664"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/266220-rustdoc/topic/review%20request%3A%20PR%20%2384867%20%28revert%20of%20PR%2080653%29/near/237187664" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/266220-rustdoc/topic/review.20request.3A.20PR.20.2384867.20(revert.20of.20PR.2080653).html#237187664">(May 03 2021 at 16:19)</a>:</h4>
<p>Had to feed twins lunch</p>



<a name="237187692"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/266220-rustdoc/topic/review%20request%3A%20PR%20%2384867%20%28revert%20of%20PR%2080653%29/near/237187692" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/266220-rustdoc/topic/review.20request.3A.20PR.20.2384867.20(revert.20of.20PR.2080653).html#237187692">(May 03 2021 at 16:20)</a>:</h4>
<p>(Childcare out sick)</p>



<a name="237188458"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/266220-rustdoc/topic/review%20request%3A%20PR%20%2384867%20%28revert%20of%20PR%2080653%29/near/237188458" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/266220-rustdoc/topic/review.20request.3A.20PR.20.2384867.20(revert.20of.20PR.2080653).html#237188458">(May 03 2021 at 16:25)</a>:</h4>
<p><span class="user-mention" data-user-id="116122">@simulacrum</span> hurm. When I leave <code>channel = …</code> as the default, I get: <code>error: no </code>rustfmt<code> binary found in /media/pnkfelix/Rust/rust.git/objdir-512cgu/build/x86_64-unknown-linux-gnu/stage0/bin</code></p>



<a name="237188532"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/266220-rustdoc/topic/review%20request%3A%20PR%20%2384867%20%28revert%20of%20PR%2080653%29/near/237188532" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/266220-rustdoc/topic/review.20request.3A.20PR.20.2384867.20(revert.20of.20PR.2080653).html#237188532">(May 03 2021 at 16:26)</a>:</h4>
<p>yeah, that's "expected"</p>



<a name="237188556"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/266220-rustdoc/topic/review%20request%3A%20PR%20%2384867%20%28revert%20of%20PR%2080653%29/near/237188556" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/266220-rustdoc/topic/review.20request.3A.20PR.20.2384867.20(revert.20of.20PR.2080653).html#237188556">(May 03 2021 at 16:26)</a>:</h4>
<p>we need to find a better ux for it</p>



<a name="237188570"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/266220-rustdoc/topic/review%20request%3A%20PR%20%2384867%20%28revert%20of%20PR%2080653%29/near/237188570" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/266220-rustdoc/topic/review.20request.3A.20PR.20.2384867.20(revert.20of.20PR.2080653).html#237188570">(May 03 2021 at 16:26)</a>:</h4>
<p>when I change it to say <code>channel = “beta”</code>, I get <code>fatal: ambiguous argument 'refs/remotes/origin/master..HEAD': unknown revision or path not in the working tree.</code></p>



<a name="237188585"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/266220-rustdoc/topic/review%20request%3A%20PR%20%2384867%20%28revert%20of%20PR%2080653%29/near/237188585" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/266220-rustdoc/topic/review.20request.3A.20PR.20.2384867.20(revert.20of.20PR.2080653).html#237188585">(May 03 2021 at 16:26)</a>:</h4>
<p>right, you're not in a proper checkout I imagine?</p>



<a name="237188593"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/266220-rustdoc/topic/review%20request%3A%20PR%20%2384867%20%28revert%20of%20PR%2080653%29/near/237188593" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/266220-rustdoc/topic/review.20request.3A.20PR.20.2384867.20(revert.20of.20PR.2080653).html#237188593">(May 03 2021 at 16:26)</a>:</h4>
<p>what’s a “proper” checkout?</p>



<a name="237188594"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/266220-rustdoc/topic/review%20request%3A%20PR%20%2384867%20%28revert%20of%20PR%2080653%29/near/237188594" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/266220-rustdoc/topic/review.20request.3A.20PR.20.2384867.20(revert.20of.20PR.2080653).html#237188594">(May 03 2021 at 16:26)</a>:</h4>
<p>i.e., refs/remotes/origin != rust-lang/rust</p>



<a name="237188639"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/266220-rustdoc/topic/review%20request%3A%20PR%20%2384867%20%28revert%20of%20PR%2080653%29/near/237188639" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/266220-rustdoc/topic/review.20request.3A.20PR.20.2384867.20(revert.20of.20PR.2080653).html#237188639">(May 03 2021 at 16:27)</a>:</h4>
<p>origin  git@github.com:rust-lang/rust.git (fetch)                                                                                                                   |</p>



<a name="237188654"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/266220-rustdoc/topic/review%20request%3A%20PR%20%2384867%20%28revert%20of%20PR%2080653%29/near/237188654" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/266220-rustdoc/topic/review.20request.3A.20PR.20.2384867.20(revert.20of.20PR.2080653).html#237188654">(May 03 2021 at 16:27)</a>:</h4>
<p>(that’s from <code>git remote -v</code></p>



<a name="237188683"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/266220-rustdoc/topic/review%20request%3A%20PR%20%2384867%20%28revert%20of%20PR%2080653%29/near/237188683" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/266220-rustdoc/topic/review.20request.3A.20PR.20.2384867.20(revert.20of.20PR.2080653).html#237188683">(May 03 2021 at 16:27)</a>:</h4>
<p>which seems to match what you wrote?</p>



<a name="237188685"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/266220-rustdoc/topic/review%20request%3A%20PR%20%2384867%20%28revert%20of%20PR%2080653%29/near/237188685" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/266220-rustdoc/topic/review.20request.3A.20PR.20.2384867.20(revert.20of.20PR.2080653).html#237188685">(May 03 2021 at 16:27)</a>:</h4>
<p>fwiw I also had this error locally but I chalked it up to my not having an origin setup</p>



<a name="237188803"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/266220-rustdoc/topic/review%20request%3A%20PR%20%2384867%20%28revert%20of%20PR%2080653%29/near/237188803" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/266220-rustdoc/topic/review.20request.3A.20PR.20.2384867.20(revert.20of.20PR.2080653).html#237188803">(May 03 2021 at 16:28)</a>:</h4>
<p>does <code>git rev-list refs/remotes/origin/master..HEAD</code> work for you?</p>



<a name="237188822"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/266220-rustdoc/topic/review%20request%3A%20PR%20%2384867%20%28revert%20of%20PR%2080653%29/near/237188822" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/266220-rustdoc/topic/review.20request.3A.20PR.20.2384867.20(revert.20of.20PR.2080653).html#237188822">(May 03 2021 at 16:28)</a>:</h4>
<p>to be fair, <code>git branch -a</code> doesn’t list anything for <code>remotes/origin</code></p>



<a name="237188829"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/266220-rustdoc/topic/review%20request%3A%20PR%20%2384867%20%28revert%20of%20PR%2080653%29/near/237188829" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/266220-rustdoc/topic/review.20request.3A.20PR.20.2384867.20(revert.20of.20PR.2080653).html#237188829">(May 03 2021 at 16:29)</a>:</h4>
<p>so maybe I need to fetch?</p>



<a name="237188881"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/266220-rustdoc/topic/review%20request%3A%20PR%20%2384867%20%28revert%20of%20PR%2080653%29/near/237188881" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/266220-rustdoc/topic/review.20request.3A.20PR.20.2384867.20(revert.20of.20PR.2080653).html#237188881">(May 03 2021 at 16:29)</a>:</h4>
<p><span class="user-mention silent" data-user-id="116122">simulacrum</span> <a href="#narrow/stream/266220-rustdoc/topic/review.20request.3A.20PR.20.2384867.20.28revert.20of.20PR.2080653.29/near/237188803">said</a>:</p>
<blockquote>
<p>does <code>git rev-list refs/remotes/origin/master..HEAD</code> work for you?</p>
</blockquote>
<p>no it doesn't</p>



<a name="237188891"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/266220-rustdoc/topic/review%20request%3A%20PR%20%2384867%20%28revert%20of%20PR%2080653%29/near/237188891" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/266220-rustdoc/topic/review.20request.3A.20PR.20.2384867.20(revert.20of.20PR.2080653).html#237188891">(May 03 2021 at 16:29)</a>:</h4>
<p>what is tidy doing here?</p>



<a name="237188892"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/266220-rustdoc/topic/review%20request%3A%20PR%20%2384867%20%28revert%20of%20PR%2080653%29/near/237188892" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/266220-rustdoc/topic/review.20request.3A.20PR.20.2384867.20(revert.20of.20PR.2080653).html#237188892">(May 03 2021 at 16:29)</a>:</h4>
<p>hm</p>



<a name="237188900"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/266220-rustdoc/topic/review%20request%3A%20PR%20%2384867%20%28revert%20of%20PR%2080653%29/near/237188900" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/266220-rustdoc/topic/review.20request.3A.20PR.20.2384867.20(revert.20of.20PR.2080653).html#237188900">(May 03 2021 at 16:29)</a>:</h4>
<p>so this isn't tidy</p>



<a name="237188907"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/266220-rustdoc/topic/review%20request%3A%20PR%20%2384867%20%28revert%20of%20PR%2080653%29/near/237188907" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/266220-rustdoc/topic/review.20request.3A.20PR.20.2384867.20(revert.20of.20PR.2080653).html#237188907">(May 03 2021 at 16:29)</a>:</h4>
<p>(I’ll try <code>git fetch origin</code>)</p>



<a name="237188912"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/266220-rustdoc/topic/review%20request%3A%20PR%20%2384867%20%28revert%20of%20PR%2080653%29/near/237188912" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/266220-rustdoc/topic/review.20request.3A.20PR.20.2384867.20(revert.20of.20PR.2080653).html#237188912">(May 03 2021 at 16:29)</a>:</h4>
<p>this is bootstrap, trying to figure out what beta you want</p>



<a name="237188916"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/266220-rustdoc/topic/review%20request%3A%20PR%20%2384867%20%28revert%20of%20PR%2080653%29/near/237188916" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/266220-rustdoc/topic/review.20request.3A.20PR.20.2384867.20(revert.20of.20PR.2080653).html#237188916">(May 03 2021 at 16:29)</a>:</h4>
<p>oh</p>



<a name="237188922"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/266220-rustdoc/topic/review%20request%3A%20PR%20%2384867%20%28revert%20of%20PR%2080653%29/near/237188922" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/266220-rustdoc/topic/review.20request.3A.20PR.20.2384867.20(revert.20of.20PR.2080653).html#237188922">(May 03 2021 at 16:29)</a>:</h4>
<p>i.e., beta.X</p>



<a name="237188987"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/266220-rustdoc/topic/review%20request%3A%20PR%20%2384867%20%28revert%20of%20PR%2080653%29/near/237188987" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/266220-rustdoc/topic/review.20request.3A.20PR.20.2384867.20(revert.20of.20PR.2080653).html#237188987">(May 03 2021 at 16:30)</a>:</h4>
<p>what does <code>ls .git/refs/</code> say?</p>



<a name="237188996"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/266220-rustdoc/topic/review%20request%3A%20PR%20%2384867%20%28revert%20of%20PR%2080653%29/near/237188996" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/266220-rustdoc/topic/review.20request.3A.20PR.20.2384867.20(revert.20of.20PR.2080653).html#237188996">(May 03 2021 at 16:30)</a>:</h4>
<p>odd that I feel like I only get this error from doing tidy though</p>



<a name="237189021"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/266220-rustdoc/topic/review%20request%3A%20PR%20%2384867%20%28revert%20of%20PR%2080653%29/near/237189021" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/266220-rustdoc/topic/review.20request.3A.20PR.20.2384867.20(revert.20of.20PR.2080653).html#237189021">(May 03 2021 at 16:30)</a>:</h4>
<p>I think you weren't on channel=beta before?</p>



<a name="237189027"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/266220-rustdoc/topic/review%20request%3A%20PR%20%2384867%20%28revert%20of%20PR%2080653%29/near/237189027" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/266220-rustdoc/topic/review.20request.3A.20PR.20.2384867.20(revert.20of.20PR.2080653).html#237189027">(May 03 2021 at 16:30)</a>:</h4>
<p>oh, I guess I haven’t tried the full build with <code>channel = beta</code></p>



<a name="237189033"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/266220-rustdoc/topic/review%20request%3A%20PR%20%2384867%20%28revert%20of%20PR%2080653%29/near/237189033" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/266220-rustdoc/topic/review.20request.3A.20PR.20.2384867.20(revert.20of.20PR.2080653).html#237189033">(May 03 2021 at 16:30)</a>:</h4>
<p>irght</p>



<a name="237189035"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/266220-rustdoc/topic/review%20request%3A%20PR%20%2384867%20%28revert%20of%20PR%2080653%29/near/237189035" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/266220-rustdoc/topic/review.20request.3A.20PR.20.2384867.20(revert.20of.20PR.2080653).html#237189035">(May 03 2021 at 16:30)</a>:</h4>
<p>okay</p>



<a name="237189054"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/266220-rustdoc/topic/review%20request%3A%20PR%20%2384867%20%28revert%20of%20PR%2080653%29/near/237189054" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/266220-rustdoc/topic/review.20request.3A.20PR.20.2384867.20(revert.20of.20PR.2080653).html#237189054">(May 03 2021 at 16:30)</a>:</h4>
<p><code>git fetch origin</code> fixed it</p>



<a name="237189088"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/266220-rustdoc/topic/review%20request%3A%20PR%20%2384867%20%28revert%20of%20PR%2080653%29/near/237189088" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/266220-rustdoc/topic/review.20request.3A.20PR.20.2384867.20(revert.20of.20PR.2080653).html#237189088">(May 03 2021 at 16:31)</a>:</h4>
<p>(maybe we need to make our error diagnostic there suggest it, not sure…)</p>



<a name="237189143"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/266220-rustdoc/topic/review%20request%3A%20PR%20%2384867%20%28revert%20of%20PR%2080653%29/near/237189143" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/266220-rustdoc/topic/review.20request.3A.20PR.20.2384867.20(revert.20of.20PR.2080653).html#237189143">(May 03 2021 at 16:31)</a>:</h4>
<p>interesting. oh well. not entirely expected</p>



<a name="237189171"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/266220-rustdoc/topic/review%20request%3A%20PR%20%2384867%20%28revert%20of%20PR%2080653%29/near/237189171" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/266220-rustdoc/topic/review.20request.3A.20PR.20.2384867.20(revert.20of.20PR.2080653).html#237189171">(May 03 2021 at 16:31)</a>:</h4>
<p>(I suspect something may have changed in git, as I've only seen it today)</p>



<a name="237190922"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/266220-rustdoc/topic/review%20request%3A%20PR%20%2384867%20%28revert%20of%20PR%2080653%29/near/237190922" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/266220-rustdoc/topic/review.20request.3A.20PR.20.2384867.20(revert.20of.20PR.2080653).html#237190922">(May 03 2021 at 16:45)</a>:</h4>
<p><span class="user-mention silent" data-user-id="116122">simulacrum</span> <a href="#narrow/stream/266220-rustdoc/topic/review.20request.3A.20PR.20.2384867.20.28revert.20of.20PR.2080653.29/near/237187400">said</a>:</p>
<blockquote>
<p><span class="user-mention silent" data-user-id="116083">pnkfelix</span> any update on the tidy fixes?</p>
</blockquote>
<p>PR <a href="https://github.com/rust-lang/rust/issues/84867">#84867</a> (nightly) is r+’ed and the (totally different!) fix to PR <a href="https://github.com/rust-lang/rust/issues/84868">#84868</a> (beta) is pushed to GitHub and awaiting CI.</p>



<a name="237191305"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/266220-rustdoc/topic/review%20request%3A%20PR%20%2384867%20%28revert%20of%20PR%2080653%29/near/237191305" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/266220-rustdoc/topic/review.20request.3A.20PR.20.2384867.20(revert.20of.20PR.2080653).html#237191305">(May 03 2021 at 16:48)</a>:</h4>
<p>Sounds good, thanks</p>



<hr><p>Last updated: Aug 07 2021 at 22:04 UTC</p>
</html>